Fixed and improved tests for non-npm usage #29
Merged
+102
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes:
File path used in fake commits for tests were from the wrong directory, fixed that.
currentWorkspace
definition wasn't generic and would fail for other project file structure, see thesubstring(11)
innpm-auto-plugins/packages/filter-by-workspace-path/src/index.ts
Line 56 in b509925
Also removed:
as I couldn't see this behaviour when testing, instead I think the reason for this codepath was the mistake in 1.
non-npm
usage.